[webkit-reviews] review denied: [Bug 186859] Add API for configuring the number of threads used by DFG and FTL : [Attachment 343185] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 20 15:41:29 PDT 2018


Keith Miller <keith_miller at apple.com> has denied Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 186859: Add API for configuring the number of threads used by DFG and FTL
https://bugs.webkit.org/show_bug.cgi?id=186859

Attachment 343185: Patch

https://bugs.webkit.org/attachment.cgi?id=343185&action=review




--- Comment #4 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 343185
  --> https://bugs.webkit.org/attachment.cgi?id=343185
Patch

I think we should have a single function that specifies the number of threads
our compilers and do our own balancing. The fact that we have two tiers is too
low of an implementation detail to expose to our clients, IMO.


More information about the webkit-reviews mailing list