[webkit-reviews] review granted: [Bug 186836] [GTK][WPE][Nicosia] Add name for Nicosia Painting Threads : [Attachment 343139] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 186836: [GTK][WPE][Nicosia] Add name for Nicosia Painting Threads
https://bugs.webkit.org/show_bug.cgi?id=186836

Attachment 343139: Patch

https://bugs.webkit.org/attachment.cgi?id=343139&action=review




--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 343139
  --> https://bugs.webkit.org/attachment.cgi?id=343139
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343139&action=review

>>>>>> Source/WTF/wtf/WorkerPool.h:66
>>>>>> +    const char* m_name;
>>>>> 
>>>>> This is a problem if the passed name is not a static string. I think it
would be safer to use a CString even if we have to duplicate it, no?
>>>> 
>>>> Is there the use case of the non-static string for WorkerPool name? I
think ASCIILiteral would be nice, but I'm not sure CString is necessary.
>>> 
>>> I don't know, if you are sure a static string is always going to be used,
I'm fine.
>> 
>> I would like to keep thread names as static if we do not have strong use
cases, because static thread names are easy to grep, and the code shows clear
intention (this thread is for "XXX") :)
> 
> Ok, is there a way to enforce it?

This is a problem if the passed name is not a static string. I think it would
be safer to use a CString even if we have to duplicate it, no?