[webkit-reviews] review granted: [Bug 186828] flattenDictionaryStructure needs to zero properties that have been compressed away : [Attachment 343122] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 186828: flattenDictionaryStructure needs to zero properties that have been
compressed away
https://bugs.webkit.org/show_bug.cgi?id=186828

Attachment 343122: Patch

https://bugs.webkit.org/attachment.cgi?id=343122&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 343122
  --> https://bugs.webkit.org/attachment.cgi?id=343122
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343122&action=review

r=me

> Source/JavaScriptCore/runtime/Structure.cpp:783
> +	   // We need to make sure we zero our unused butterfly space otherwise
the GC might see a stale pointer.

I think you can drop the "make sure we" part, and I suggest adding a semicolon
after "space" and a comma after "otherwise".