[webkit-reviews] review granted: [Bug 186806] REGRESSION (r231850): Cookie file cannot be read or written by network process : [Attachment 343069] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 186806: REGRESSION (r231850): Cookie file cannot be read or written by
network process
https://bugs.webkit.org/show_bug.cgi?id=186806

Attachment 343069: Patch

https://bugs.webkit.org/attachment.cgi?id=343069&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 343069
  --> https://bugs.webkit.org/attachment.cgi?id=343069
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343069&action=review

r=me

This bug is super mysterious, and it should trigger in our API tests bug
doesn't. I think it's worth your time to do a little more debugging to come up
with a possibly more cohesive story of this bug -- maybe that path will teach
us how to write a regression test for this.

> Source/WebKit/ChangeLog:10
> +	   Default websiteDataStore may be added wrongly to network process
before default session was 
> +	   set, as messages were asynchronous, so the cookie storage could be
improperly set.   

Even though messages are async, they are guaranteed to arrive in order. So, I
don't think it's possible for the AddWebsiteDataStore message to arrive before
the Initialize message. (You can try this out if you're curious.)

But, we do know by testing that moving the initialization of pending cookies to
the initialization message fixes this bug. So I think that's a good change.