[webkit-reviews] review denied: [Bug 186540] ShadowChicken crashes with stack overflow in the LLInt : [Attachment 343093] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has denied Tadeu Zagallo <tzagallo at apple.com>'s
request for review:
Bug 186540: ShadowChicken crashes with stack overflow in the LLInt
https://bugs.webkit.org/show_bug.cgi?id=186540

Attachment 343093: Patch

https://bugs.webkit.org/attachment.cgi?id=343093&action=review




--- Comment #35 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 343093
  --> https://bugs.webkit.org/attachment.cgi?id=343093
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343093&action=review

> Source/JavaScriptCore/interpreter/ShadowChicken.cpp:306
> +	       if (scopeValue.isUndefined() &&
codeBlock->wasCompiledWithDebuggingOpcodes() && !scopeValue.isUndefined()) {

this code is wrong. It can't both be undefined and not undefined.