[webkit-reviews] review granted: [Bug 185266] [Curl] Enable Proxy Authentication. : [Attachment 343088] FIX
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 19 13:57:25 PDT 2018
Alex Christensen <achristensen at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 185266: [Curl] Enable Proxy Authentication.
https://bugs.webkit.org/show_bug.cgi?id=185266
Attachment 343088: FIX
https://bugs.webkit.org/attachment.cgi?id=343088&action=review
--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 343088
--> https://bugs.webkit.org/attachment.cgi?id=343088
FIX
View in context: https://bugs.webkit.org/attachment.cgi?id=343088&action=review
> Source/WebCore/platform/network/curl/AuthenticationChallengeCurl.cpp:68
> +int AuthenticationChallenge::determineProxyPort(const URL& url)
This should return a std::optional<uint16_t>
More information about the webkit-reviews
mailing list