[webkit-reviews] review granted: [Bug 183818] [Web Animations] Make imported/mozilla/css-animations/test_pseudoElement-get-animations.html pass reliably : [Attachment 343062] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 183818: [Web Animations] Make
imported/mozilla/css-animations/test_pseudoElement-get-animations.html pass
reliably
https://bugs.webkit.org/show_bug.cgi?id=183818

Attachment 343062: Patch

https://bugs.webkit.org/attachment.cgi?id=343062&action=review




--- Comment #6 from Dean Jackson <dino at apple.com> ---
Comment on attachment 343062
  --> https://bugs.webkit.org/attachment.cgi?id=343062
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343062&action=review

> Source/WebCore/animation/AnimationTimeline.cpp:145
> +Vector<RefPtr<WebAnimation>>
AnimationTimeline::animationsForElement(Element& element, bool sorted) const

Use a enum class Ordering::Sorted Ordering::Unsorted rather than a bool
parameter

> Source/WebCore/animation/AnimationTimeline.cpp:160
> +		   if (lhsTransition->generationTime() ==
rhsTransition->generationTime())
> +		       return lhsTransition->transitionProperty().utf8() <
rhsTransition->transitionProperty().utf8();
> +		   return lhsTransition->generationTime() <
rhsTransition->generationTime();

Make the logic here match the comment

if (l->genTime != r->genTime)
  return l->genTime < r->genTime;

return l->prop < r->prop