[webkit-reviews] review denied: [Bug 186763] bmalloc: Coverity scan issues : [Attachment 342932] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 18 12:50:35 PDT 2018

Geoffrey Garen <ggaren at apple.com> has denied Tomas Popela
<tpopela at redhat.com>'s request for review:
Bug 186763: bmalloc: Coverity scan issues

Attachment 342932: Patch


--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 342932
  --> https://bugs.webkit.org/attachment.cgi?id=342932

View in context: https://bugs.webkit.org/attachment.cgi?id=342932&action=review

> Source/bmalloc/bmalloc/VMAllocate.h:61
> +	   cached = pageSize < 0 ? smallPageSize : pageSize;

This is not a meaningful default. You probably need to crash here too.

More information about the webkit-reviews mailing list