[webkit-reviews] review granted: [Bug 186517] [Web Animations] Implement "Starting of transitions" section from CSS Transitions : [Attachment 342939] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 186517: [Web Animations] Implement "Starting of transitions" section from
CSS Transitions
https://bugs.webkit.org/show_bug.cgi?id=186517

Attachment 342939: Patch

https://bugs.webkit.org/attachment.cgi?id=342939&action=review




--- Comment #5 from Dean Jackson <dino at apple.com> ---
Comment on attachment 342939
  --> https://bugs.webkit.org/attachment.cgi?id=342939
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342939&action=review

> Source/WebCore/animation/AnimationTimeline.cpp:171
> +void AnimationTimeline::updateCSSAnimationsForElement(Element& element,
const RenderStyle* currentStyle, const RenderStyle& afterChangeStyle)

Can you keep the currentStyle as a &, since you check for null when you call
the method? I guess you still have the case where afterStyleChange has a value
but currentStyle doesn't?