[webkit-reviews] review granted: [Bug 186692] Properly zero unused property storage offsets : [Attachment 342873] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 18 11:34:42 PDT 2018


Filip Pizlo <fpizlo at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 186692: Properly zero unused property storage offsets
https://bugs.webkit.org/show_bug.cgi?id=186692

Attachment 342873: Patch

https://bugs.webkit.org/attachment.cgi?id=342873&action=review




--- Comment #25 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 342873
  --> https://bugs.webkit.org/attachment.cgi?id=342873
Patch

I would rip out the part of this patch that adds more uses of
ObjectInitializationScope.  In RegExpMatchesArray, we already use
GCDeferralContext, which may not interact great with the DisallowGC that
ObjectInitializationScope does.


More information about the webkit-reviews mailing list