[webkit-reviews] review denied: [Bug 186765] [Armv7] Linkbuffer: executableOffsetFor() fails for location 2 : [Attachment 342936] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has denied Guillaume Emont
<guijemont at igalia.com>'s request for review:
Bug 186765: [Armv7] Linkbuffer: executableOffsetFor() fails for location 2
https://bugs.webkit.org/show_bug.cgi?id=186765

Attachment 342936: Patch

https://bugs.webkit.org/attachment.cgi?id=342936&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 342936
  --> https://bugs.webkit.org/attachment.cgi?id=342936
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342936&action=review

> Source/JavaScriptCore/assembler/LinkBuffer.h:300
> -	   if (!location)
> +	   if (location < sizeof(int32_t))

Why is it ever valid to pass a location of 2 and expect it to map to an offset
of 0?  It looks to me like this change is trying to mask the bug instead of
fixing it.  Please provide justification as why this is valid, or if this isn't
the real issue, fix the real issue instead.