[webkit-reviews] review requested: [Bug 186678] [GStreamer] Some media stream tests are crashing : [Attachment 342940] Patch.

[bugzilla-daemon at webkit.org]

Thibault Saunier <tsaunier at gnome.org> has asked  for review:
Bug 186678: [GStreamer] Some media stream tests are crashing
https://bugs.webkit.org/show_bug.cgi?id=186678

Attachment 342940: Patch.

https://bugs.webkit.org/attachment.cgi?id=342940&action=review




--- Comment #2 from Thibault Saunier <tsaunier at gnome.org> ---
Created attachment 342940

  --> https://bugs.webkit.org/attachment.cgi?id=342940&action=review

Patch.

Note that I was not able to reproduce those crashes running the tests locally
or on our buildbox but I had a very similare segfault running MiniBrowser in
some rare cases and this patch seems/should to fix it. I think it is
conceptually
correct/better anyway.

I am investigating the root cause of that issue, but the decodebin3 code is
still
moving quite fast and not being able to reproduce properly myself is annoying.

The approach taken here is to make sure to not do "stupid things" on our end so
that we avoid hitting the race in decodebin3, still the bug is still there.