[webkit-reviews] review requested: [Bug 186765] [Armv7] Linkbuffer: executableOffsetFor() fails for location 2 : [Attachment 342936] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 18 07:53:10 PDT 2018

Guillaume Emont <guijemont at igalia.com> has asked  for review:
Bug 186765: [Armv7] Linkbuffer: executableOffsetFor() fails for location 2

Attachment 342936: Patch


--- Comment #1 from Guillaume Emont <guijemont at igalia.com> ---
Created attachment 342936

  --> https://bugs.webkit.org/attachment.cgi?id=342936&action=review


This seems to fix it. I'm unsure of how
recordLinkOffsets()/executableOffsetFor() are supposed to work on thumb2, as
they seem to assume that jump origins and destinations are 4-byte aligned,
though I might be misunderstanding something, as it looks like this has been
working like that since the introduction of thumb2 support.

More information about the webkit-reviews mailing list