[webkit-reviews] review granted: [Bug 186708] CSSFontFace wastes 59KB of Vector capacity on nytimes.com : [Attachment 342906] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 186708: CSSFontFace wastes 59KB of Vector capacity on nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=186708

Attachment 342906: Patch

https://bugs.webkit.org/attachment.cgi?id=342906&action=review




--- Comment #3 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 342906
  --> https://bugs.webkit.org/attachment.cgi?id=342906
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342906&action=review

> Source/WebCore/css/CSSFontFace.h:187
> +    Vector<std::unique_ptr<CSSFontFaceSource>, 0, CrashOnOverflow, 0>
m_sources;

This declaration is really confusing, it's not at all clear what the zeroes
mean.

I wonder if it could be made more clear by adding a template alias declaration
to Vector.h.