[webkit-reviews] review granted: [Bug 186566] Semantic colors should not be transformed by color-filter : [Attachment 342811] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 15 13:09:13 PDT 2018

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 186566: Semantic colors should not be transformed by color-filter

Attachment 342811: patch


--- Comment #18 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 342811
  --> https://bugs.webkit.org/attachment.cgi?id=342811

View in context: https://bugs.webkit.org/attachment.cgi?id=342811&action=review

> Source/WebCore/rendering/RenderTreeAsText.cpp:245
> -	       if (o.parent()->style().visitedDependentColor(CSSPropertyColor)
!= color)
> +	       if
(o.parent()->style().visitedDependentColor(CSSPropertyColor).rgb() !=

Really confusing that "rgb()" includes alpha. It looks like these comparisons
are ignoring alpha.

Maybe add an explicit bool Color::rgbaEquals(const Color&) or something.

More information about the webkit-reviews mailing list