[webkit-reviews] review granted: [Bug 186640] [LFC] Fix static position left/top : [Attachment 342785] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 186640: [LFC] Fix static position left/top
https://bugs.webkit.org/show_bug.cgi?id=186640

Attachment 342785: Patch

https://bugs.webkit.org/attachment.cgi?id=342785&action=review




--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 342785
  --> https://bugs.webkit.org/attachment.cgi?id=342785
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342785&action=review

> Source/WebCore/layout/FormattingContext.h:86
> +	       LayoutUnit y; // top
> +	       LayoutUnit x; // left

Maybe we could have something like LayoutUnit<Vertical> and
LayoutUnit<Horizontal> so mixing would require explicit conversions?