[webkit-reviews] review requested: [Bug 185611] [GTK][WPE]: Avoid trying to getenv with an unset varname : [Attachment 342812] Patch.

[bugzilla-daemon at webkit.org]

Thibault Saunier <tsaunier at gnome.org> has asked  for review:
Bug 185611: [GTK][WPE]: Avoid trying to getenv with an unset varname
https://bugs.webkit.org/show_bug.cgi?id=185611

Attachment 342812: Patch.

https://bugs.webkit.org/attachment.cgi?id=342812&action=review




--- Comment #33 from Thibault Saunier <tsaunier at gnome.org> ---
Created attachment 342812

  --> https://bugs.webkit.org/attachment.cgi?id=342812&action=review

Patch.

(In reply to Chris Dumez from comment #32)
> I think we should either:
> - Not add new enum value and just swap the instructions here.
> or (if we want to provide some validation that the processType gets set):
> - Rename None to Unset (or Invalid) & ASSERT in
> ChildProcessProxy::getLaunchOptions() that processType is not Unset/Invalid.

I decided to keep it simple and just swap the lines.