[webkit-reviews] review granted: [Bug 186615] Activate -Wexit-time-destructors -and Wglobal-constructors in libwebrtc : [Attachment 342748] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 14 15:38:13 PDT 2018


Darin Adler <darin at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 186615: Activate -Wexit-time-destructors -and Wglobal-constructors in
libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=186615

Attachment 342748: Patch

https://bugs.webkit.org/attachment.cgi?id=342748&action=review




--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 342748
  --> https://bugs.webkit.org/attachment.cgi?id=342748
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342748&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.cc:148
> -  std::call_once(callLogCriticalScopeOnce,[] { logCriticalScope(); });
> +  std::call_once(callLogCriticalScopeOnce,[] {
> +    logCriticalScope();
> +  });

Seems like this formatting change is not needed.


More information about the webkit-reviews mailing list