[webkit-reviews] review denied: [Bug 185611] [GTK][WPE]: Avoid trying to getenv with an unset varname : [Attachment 341289] Update to avoid `enumeration value 'None' not handled in switch` issues in Apple's code.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 14 14:39:02 PDT 2018


Chris Dumez <cdumez at apple.com> has denied Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 185611: [GTK][WPE]: Avoid trying to getenv with an unset varname
https://bugs.webkit.org/show_bug.cgi?id=185611

Attachment 341289: Update to avoid `enumeration value 'None' not handled in
switch` issues in Apple's code.

https://bugs.webkit.org/attachment.cgi?id=341289&action=review




--- Comment #28 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 341289
  --> https://bugs.webkit.org/attachment.cgi?id=341289
Update to avoid `enumeration value 'None' not handled in switch` issues in
Apple's code.

Looks to me that the problem is that GTK's implementation of
PluginProcessProxy::platformGetLaunchOptions() fails to set
launchOptions.processType.


More information about the webkit-reviews mailing list