[webkit-reviews] review granted: [Bug 186579] Share structure across instances of classes exported through the ObjC API : [Attachment 342730] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 14 10:58:01 PDT 2018


Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 186579: Share structure across instances of classes exported through the
ObjC API
https://bugs.webkit.org/show_bug.cgi?id=186579

Attachment 342730: Patch

https://bugs.webkit.org/attachment.cgi?id=342730&action=review




--- Comment #11 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 342730
  --> https://bugs.webkit.org/attachment.cgi?id=342730
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342730&action=review

r=me

> Source/JavaScriptCore/API/JSWrapperMap.mm:521
> +    auto structure = [self structureInContext:context];

I think we tend to use auto* here or write out the type. Ditto in below uses


More information about the webkit-reviews mailing list