[webkit-reviews] review granted: [Bug 186459] [DFG] Fold GetByVal if Array is CoW : [Attachment 342578] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 186459: [DFG] Fold GetByVal if Array is CoW
https://bugs.webkit.org/show_bug.cgi?id=186459

Attachment 342578: Patch

https://bugs.webkit.org/attachment.cgi?id=342578&action=review




--- Comment #29 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 342578
  --> https://bugs.webkit.org/attachment.cgi?id=342578
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342578&action=review

r=me

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1848
> +		   int32_t index = indexConstant.asInt32();

Nit: I’d use uint32_t here and asUint32