[webkit-reviews] review granted: [Bug 186602] [JSC] Remove cellLock in JSObject::convertContiguousToArrayStorage : [Attachment 342731] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 186602: [JSC] Remove cellLock in JSObject::convertContiguousToArrayStorage
https://bugs.webkit.org/show_bug.cgi?id=186602

Attachment 342731: Patch

https://bugs.webkit.org/attachment.cgi?id=342731&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 342731
  --> https://bugs.webkit.org/attachment.cgi?id=342731
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342731&action=review

r=me

> Source/JavaScriptCore/runtime/JSObject.cpp:1350
> +    // Our following operations are sequentially executed by using
storeStoreFence.

Our following => The mutator performs the following

> Source/JavaScriptCore/runtime/JSObject.cpp:1402
> +    WTF::storeStoreFence();

You only need this for mutatorShouldBeFenced, right?