[webkit-reviews] review granted: [Bug 186219] [GTK] Correct behavior for dark themes : [Attachment 342732] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 14 09:51:44 PDT 2018
Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Eduardo Ramalho
<cadubentzen at gmail.com>'s request for review:
Bug 186219: [GTK] Correct behavior for dark themes
https://bugs.webkit.org/show_bug.cgi?id=186219
Attachment 342732: Patch
https://bugs.webkit.org/attachment.cgi?id=342732&action=review
--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 342732
--> https://bugs.webkit.org/attachment.cgi?id=342732
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=342732&action=review
Makes sense to me.
I wonder if Carlos Garcia will want to review this, as well.
> Source/WebCore/rendering/RenderThemeGtk.cpp:930
> + if ((style.appearance() == TextFieldPart || style.appearance() ==
TextAreaPart || style.appearance() == SearchFieldPart) && style.color() !=
RenderStyle::initialColor())
> + return true;
This is confusing enough that it merits a comment in the code to explain what
is going on, I think.
> LayoutTests/platform/gtk/TestExpectations:3399
> +# When text input colors are set we do not style with GTK, so these reftests
will fail
> +webkit.org/b/186219 fast/forms/input-placeholder-text-indent.html [
ImageOnlyFailure ]
> +webkit.org/b/186219 fast/forms/password-placeholder-text-security.html [
ImageOnlyFailure ]
> +webkit.org/b/186219 fast/forms/placeholder-with-positioned-element.html [
ImageOnlyFailure ]
> +webkit.org/b/186219 fast/forms/textarea-placeholder-wrapping.html [
ImageOnlyFailure ]
Since these are desired failures, they should go at the top of the file under
section two.
More information about the webkit-reviews
mailing list