[webkit-reviews] review granted: [Bug 166885] [GTK] Add a script to upload the data generated with run-benchmark to a browserperfdash server and use it on the gtk perf bot : [Attachment 342418] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Alberto Lopez
Perez <clopez at igalia.com>'s request for review:
Bug 166885: [GTK] Add a script to upload the data generated with run-benchmark
to a browserperfdash server and use it on the gtk perf bot
https://bugs.webkit.org/show_bug.cgi?id=166885

Attachment 342418: Patch

https://bugs.webkit.org/attachment.cgi?id=342418&action=review




--- Comment #15 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 342418
  --> https://bugs.webkit.org/attachment.cgi?id=342418
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342418&action=review

Just giving this a cursory review... I think this avoids Ryusoke's concerns,
right?

> Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:74
> +	   # This is the dictionary that will be sent in the post petition that
browserperfdash expects

"post petition"? What does this mean? I guess you meant to write something else
here?

> Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:194
> +	       _log.error('The following benchmark plans have failed to run or
to upload : {list_plan_failed}'.format(list_plan_failed=failed))

No space before the :