[webkit-reviews] review requested: [Bug 186588] [WPE] Trying to access the remote inspector hits an assertion in the UIProcess : [Attachment 342706] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has asked  for review:
Bug 186588: [WPE] Trying to access the remote inspector hits an assertion in
the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=186588

Attachment 342706: Patch

https://bugs.webkit.org/attachment.cgi?id=342706&action=review




--- Comment #6 from Adrian Perez <aperez at igalia.com> ---
Created attachment 342706

  --> https://bugs.webkit.org/attachment.cgi?id=342706&action=review

Patch


First I thought of adding --gtk/--wpe switches to the Python script
which generates the XML manifest passed to glib-compile-resources,
but then it dawned on me that it is not really needed to differentiate
between resources at /org/webkitgtk/inspector and /org/wpe/inspector:
they are the same, and it cannot ever happen anyway that both resource
sets are loaded into the same process... So why not just using the
same /org/webkit/inspector prefix for both ports? This way it will
be less likely that breakage is introduced again in the future.