[webkit-reviews] review granted: [Bug 132333] [CLOOP] Operand in PutToScope and GetFromScope is not set right causing crashes on big endian arches : [Attachment 342075] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 14:13:02 PDT 2018


Mark Lam <mark.lam at apple.com> has granted Caitlin Potter (:caitp)
<caitp at igalia.com>'s request for review:
Bug 132333: [CLOOP] Operand in PutToScope and GetFromScope is not set right
causing crashes on big endian arches
https://bugs.webkit.org/show_bug.cgi?id=132333

Attachment 342075: Patch

https://bugs.webkit.org/attachment.cgi?id=342075&action=review




--- Comment #33 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 342075
  --> https://bugs.webkit.org/attachment.cgi?id=342075
Patch

I'm saddened by the fact that this turns a 32bit load into a 64bit load. 
However, it's only in the interpreter.	I suppose it won't have a significant
dent on performance.  r=me.


More information about the webkit-reviews mailing list