[webkit-reviews] review granted: [Bug 186606] Web Inspector: open source Dark Mode : [Attachment 342688] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 13 13:38:27 PDT 2018

Timothy Hatcher <timothy at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 186606: Web Inspector: open source Dark Mode

Attachment 342688: Patch


--- Comment #3 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 342688
  --> https://bugs.webkit.org/attachment.cgi?id=342688

View in context: https://bugs.webkit.org/attachment.cgi?id=342688&action=review

> Source/WebInspectorUI/UserInterface/Main.html:240
> +    <link rel="stylesheet" href="Views/DarkMode.css">

It would be good to merge the rules into the other files for ease of
maintenance in a future patch.

> Source/WebInspectorUI/UserInterface/Main.html:-243
> -    <link rel="stylesheet"

Might as well keep this line, in case we need it in the future.

More information about the webkit-reviews mailing list