[webkit-reviews] review granted: [Bug 186547] [WPE] Build getUserMedia support : [Attachment 342575] Added alsa devel as required dependency in the install-dependencies script

[bugzilla-daemon at webkit.org]

Alejandro G. Castro <alex at igalia.com> has granted Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 186547: [WPE] Build getUserMedia support
https://bugs.webkit.org/show_bug.cgi?id=186547

Attachment 342575: Added alsa devel as required dependency in the
install-dependencies script

https://bugs.webkit.org/attachment.cgi?id=342575&action=review




--- Comment #12 from Alejandro G. Castro <alex at igalia.com> ---
Comment on attachment 342575
  --> https://bugs.webkit.org/attachment.cgi?id=342575
Added alsa devel as required dependency in the install-dependencies script

View in context: https://bugs.webkit.org/attachment.cgi?id=342575&action=review

LGTM, let's try it, I added a couple of minor modifications.

> Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:217
> +    copy = adoptRef(cairo_image_surface_create(CAIRO_FORMAT_ARGB32,

Can we do auto copy = ... here?

> Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:221
> +    cr = cairo_create(copy.get());

I think we can do: auto cr = adoptRef(cairo_create(copy.get())); And remove the
destroy of the cr later.