[webkit-reviews] review granted: [Bug 186578] Supported plugin check should be based on plugin identifier : [Attachment 342608] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 12 23:39:22 PDT 2018

Darin Adler <darin at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 186578: Supported plugin check should be based on plugin identifier

Attachment 342608: Patch


--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 342608
  --> https://bugs.webkit.org/attachment.cgi?id=342608

View in context: https://bugs.webkit.org/attachment.cgi?id=342608&action=review

> Source/WebCore/plugins/PluginData.cpp:57
> +    return plugin.bundleIdentifier == "com.apple.webkit.builtInPDFPlugin";

Seems a little unsafe to have this be a case sensitive check since bundle
identifiers are not case sensitive. Could avoid the case sensitivity by using
equalLettersIgnoringASCIICase or equalIgnoringASCIICase.

Would also be nice to not risk this getting out of sync if we change the
identifier in the future for some reason, but I suppose it’s not that terrible
to have it here.

More information about the webkit-reviews mailing list