[webkit-reviews] review granted: [Bug 186336] TileFirstPaint strategy for async image decoding should be disabled for non root RenderLayers : [Attachment 342590] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 186336: TileFirstPaint strategy for async image decoding should be disabled
for non root RenderLayers
https://bugs.webkit.org/show_bug.cgi?id=186336

Attachment 342590: Patch

https://bugs.webkit.org/attachment.cgi?id=342590&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 342590
  --> https://bugs.webkit.org/attachment.cgi?id=342590
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342590&action=review

> Source/WebCore/ChangeLog:14
> +	   had to be generalized for large and animated images. The logic for
making 
> +	   the image decoding takes the required duration was moved from
BitmapImage

"the logic for making the image decoding" doesn't make sense grammatically.

> Source/WebCore/rendering/RenderLayer.h:189
> +    bool isRoot() const { return !parent(); }

We already have isRenderViewLayer(), which should give the same answer.