[webkit-reviews] review requested: [Bug 184039] webkitpy: Implement coredumpctl support on linux : [Attachment 342576] Updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 12 12:17:08 PDT 2018
Thibault Saunier <tsaunier at gnome.org> has asked for review:
Bug 184039: webkitpy: Implement coredumpctl support on linux
https://bugs.webkit.org/show_bug.cgi?id=184039
Attachment 342576: Updated patch
https://bugs.webkit.org/attachment.cgi?id=342576&action=review
--- Comment #24 from Thibault Saunier <tsaunier at gnome.org> ---
Created attachment 342576
--> https://bugs.webkit.org/attachment.cgi?id=342576&action=review
Updated patch
(In reply to Thibault Saunier from comment #23)
> (In reply to Daniel Bates from comment #22)
> > Comment on attachment 339979 [details]
> > webkitpy: Implement coredumpctl support on linux
> >
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=339979&action=review
> >
> > > Tools/Scripts/webkitpy/port/linux_get_crash_log.py:127
> > > + ['c++filt', ], stdin=subprocess.PIPE,
stdout=subprocess.PIPE, stderr=subprocess.PIPE)
> >
> > Is the “, “ intentional in the array provided in the first argument?
Removed the trailling comma.
More information about the webkit-reviews
mailing list