[webkit-reviews] review granted: [Bug 186442] [WebKit on watchOS] Upstream watchOS source additions to OpenSource : [Attachment 342570] Form controls

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 186442: [WebKit on watchOS] Upstream watchOS source additions to OpenSource
https://bugs.webkit.org/show_bug.cgi?id=186442

Attachment 342570: Form controls

https://bugs.webkit.org/attachment.cgi?id=342570&action=review




--- Comment #8 from Tim Horton <thorton at apple.com> ---
Comment on attachment 342570
  --> https://bugs.webkit.org/attachment.cgi?id=342570
Form controls

View in context: https://bugs.webkit.org/attachment.cgi?id=342570&action=review

> Source/WebKit/UIProcess/ios/forms/WKDatePickerViewController.mm:647
> +    if (pickerView == _yearAndEraPicker)
> +	   [_yearAndEraPicker setChangingValue:YES];
> +    if (pickerView == _dayPicker)

else if?

> Source/WebKit/UIProcess/ios/forms/WKDatePickerViewController.mm:655
> +    if (pickerView == _yearAndEraPicker)

Ditto

> Source/WebKit/UIProcess/ios/forms/WKNumberPadViewController.mm:145
> +- (void)_handleKeyPress:(WKNumberPadKey)key

This is not my favorite thing in the world, but OK.

> Source/WebKit/UIProcess/ios/forms/WKNumberPadViewController.mm:258
> +    fadeOutAnimation.fromValue = @(1);

Do you need the parens?

> Source/WebKit/UIProcess/ios/forms/WKTimePickerViewController.mm:67
> +    [_dateFormatter setLocale:[NSLocale
localeWithLocaleIdentifier:@"en_US_POSIX"]];

en_US_POSIX, always?