[webkit-reviews] review granted: [Bug 186369] Add logging around internalError(const URL&) : [Attachment 342094] Fix build error
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 11 14:27:45 PDT 2018
Brent Fulgham <bfulgham at webkit.org> has granted Keith Rollin
<krollin at apple.com>'s request for review:
Bug 186369: Add logging around internalError(const URL&)
https://bugs.webkit.org/show_bug.cgi?id=186369
Attachment 342094: Fix build error
https://bugs.webkit.org/attachment.cgi?id=342094&action=review
--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 342094
--> https://bugs.webkit.org/attachment.cgi?id=342094
Fix build error
View in context: https://bugs.webkit.org/attachment.cgi?id=342094&action=review
Looks good! I suggest the modern C++ loop.
> Source/WTF/wtf/Assertions.cpp:556
> + for (int frameNumber = 1; frameNumber < stackTrace->size();
++frameNumber) {
Could this be a modern C++ loop?
for (auto stackFrame : stackTrace->stack()) {
...
More information about the webkit-reviews
mailing list