[webkit-reviews] review granted: [Bug 186523] [JSCOnly] Add a MIPS32el JSCOnly EWS : [Attachment 342439] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Alberto Lopez
Perez <clopez at igalia.com>'s request for review:
Bug 186523: [JSCOnly] Add a MIPS32el JSCOnly EWS
https://bugs.webkit.org/show_bug.cgi?id=186523

Attachment 342439: Patch

https://bugs.webkit.org/attachment.cgi?id=342439&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 342439
  --> https://bugs.webkit.org/attachment.cgi?id=342439
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342439&action=review

Yay!

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/D
ashboard.js:38
> +	   LinuxJSCOnly: { name : "linux-jsc-only", readableName: "Linux
JSCOnly", order: 92 }

For this to work, don't you also need to edit WebKitBuildbot.js?

We also need a logo under dashboard/Styles/Main.css. When I asked the compilers
team the other day, there was not much feedback in the way of a good logo, so
we might as well use https://webkit.org/blog-files/squirrelfish.png I guess.