[webkit-reviews] review granted: [Bug 186479] [MotionMark] Add support for version numbers : [Attachment 342438] Patch

[bugzilla-daemon at webkit.org]

Said Abou-Hallawa <sabouhallawa at apple.com> has granted Jon Lee
<jonlee at apple.com>'s request for review:
Bug 186479: [MotionMark] Add support for version numbers
https://bugs.webkit.org/show_bug.cgi?id=186479

Attachment 342438: Patch

https://bugs.webkit.org/attachment.cgi?id=342438&action=review




--- Comment #2 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 342438
  --> https://bugs.webkit.org/attachment.cgi?id=342438
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342438&action=review

> PerformanceTests/MotionMark/about.html:40
> +	   <div class="logo"><svg><use
xlink:href="resources/runner/logo.svg#root" /></svg></div>

I am not sure why we have to create an <svg> element which has a <use> element
and this element references a target in an eternal <svg> especially there is
only a single symbol in the logo.svg. Can't be just use

<img width="525" height="130" src="logo.svg">? And of course get rid of the
<symbol> tag from logo.svg.