[webkit-reviews] review granted: [Bug 186471] MediaTrackCapabilities.deviceId and groupId are not hashed. : [Attachment 342412] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted jianjun.zhu at intel.com's
request for review:
Bug 186471: MediaTrackCapabilities.deviceId and groupId are not hashed.
https://bugs.webkit.org/show_bug.cgi?id=186471

Attachment 342412: Patch

https://bugs.webkit.org/attachment.cgi?id=342412&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 342412
  --> https://bugs.webkit.org/attachment.cgi?id=342412
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342412&action=review

Thank you for the fix!

> LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities.html:47
> +		   if(trackKind !== 'audio' && trackKind !== 'video')

Nit: tests typically have a space between "if" and "("

> LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities.html:51
> +		       if(deviceInfo.deviceId === deviceId && deviceInfo.kind
=== deviceKind) {

Ditto.

> LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities.html:89
> +		   },e => {

Nit: missing a space between "," and "e"