[webkit-reviews] review canceled: [Bug 186459] [DFG] Fold GetByVal if Array is CoW : [Attachment 342367] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has canceled Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 186459: [DFG] Fold GetByVal if Array is CoW
https://bugs.webkit.org/show_bug.cgi?id=186459

Attachment 342367: Patch

https://bugs.webkit.org/attachment.cgi?id=342367&action=review




--- Comment #4 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 342367
  --> https://bugs.webkit.org/attachment.cgi?id=342367
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342367&action=review

>> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1829
>> +			    && (arrayEdge.useKind() == CellUse ||
arrayEdge.useKind() == KnownCellUse || !(arrayValue.m_type & ~SpecCell))) {
> 
> Doesn't AI finding a constant value guarantee this?

Right. Removed.

>> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1848
>> +						break;
> 
> Nit: I think you could handle the out of bounds case too if we are watching
for a sane chain.

OK, we can handle Array::SaneChain case :)