[webkit-reviews] review granted: [Bug 186260] Add sub-tests based on Suits : [Attachment 342328] Patch

[bugzilla-daemon at webkit.org]

Said Abou-Hallawa <sabouhallawa at apple.com> has granted Jon Lee
<jonlee at apple.com>'s request for review:
Bug 186260: Add sub-tests based on Suits
https://bugs.webkit.org/show_bug.cgi?id=186260

Attachment 342328: Patch

https://bugs.webkit.org/attachment.cgi?id=342328&action=review




--- Comment #7 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 342328
  --> https://bugs.webkit.org/attachment.cgi?id=342328
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342328&action=review

> PerformanceTests/MotionMark/tests/svg/suits.js:36
> +    isClipPath: true,
> +    hasGradient: false,

Nit: The concrete Suits classes could pass isClipPath and hasGradient to the
SuperSuitsParticle. These two data members are only used by SuperSuitsParticle.