[webkit-reviews] review granted: [Bug 186446] jumpTrueOrFalse only takes the fast path for boolean false : [Attachment 342326] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Tadeu Zagallo <tzagallo at apple.com>'s
request for review:
Bug 186446: jumpTrueOrFalse only takes the fast path for boolean false
https://bugs.webkit.org/show_bug.cgi?id=186446

Attachment 342326: Patch

https://bugs.webkit.org/attachment.cgi?id=342326&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 342326
  --> https://bugs.webkit.org/attachment.cgi?id=342326
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342326&action=review

r=me with fixes.

> Source/JavaScriptCore/ChangeLog:11
> +	   the fast path for true, false and undefined.

and null too.  This is only for 64-bit.  For 32-bit, it was already taking the
fast path for true or false, and still does for only those 2 values.  Please
add this to the ChangeLog comment so that we don't miscommunicate the scope of
this change.

> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1824
> +    btqnz t0, ~15, .slow

nit: I prefer you use ~0xf instead so that we can think in terms of the bits
being masked.