[webkit-reviews] review granted: [Bug 186397] Only display refresh monitors having requested display refresh callback should get notified on screen updates. : [Attachment 342300] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 186397: Only display refresh monitors having requested display refresh
callback should get notified on screen updates.
https://bugs.webkit.org/show_bug.cgi?id=186397

Attachment 342300: Patch

https://bugs.webkit.org/attachment.cgi?id=342300&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 342300
  --> https://bugs.webkit.org/attachment.cgi?id=342300
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342300&action=review

I think this seems like a very reasonable approach. We just need to be sure
there aren't cases where we were relying on an active monitor (that has not
sent a message recently) getting updates.

We might find that we need to be more explicit about specifically requesting
refresh callback if we encounter animation or other rendering issues.

> Source/WebCore/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=186397

Radar?

> Source/WebCore/ChangeLog:9
> +	   we should make sure that only the monitors having requested
callback, are getting notified on screen

No comma after "callback" please.

> Source/WebCore/platform/graphics/DisplayRefreshMonitorManager.cpp:131
> +	   if (monitor->hasRequestedRefreshCallback())

How frequently do we have active monitors that have not requested refresh
callbacks? I'm curious how much of a benefit this might be...