[webkit-reviews] review granted: [Bug 186421] [Win][MiniBrowser] Add a new BrowserWindow interface to abstract WK1 and WK2 BrowserWindow : [Attachment 342233] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 7 21:15:18 PDT 2018
Ryosuke Niwa <rniwa at webkit.org> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 186421: [Win][MiniBrowser] Add a new BrowserWindow interface to abstract
WK1 and WK2 BrowserWindow
https://bugs.webkit.org/show_bug.cgi?id=186421
Attachment 342233: Patch
https://bugs.webkit.org/attachment.cgi?id=342233&action=review
--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 342233
--> https://bugs.webkit.org/attachment.cgi?id=342233
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=342233&action=review
> Tools/MiniBrowser/win/PrintWebUIDelegate.cpp:74
> + MiniBrowser* newBrowserWindow =
static_cast<MiniBrowser*>(newWindow.browserWindow());
Can we use MiniBrowser& or auto& instead?
More information about the webkit-reviews
mailing list