[webkit-reviews] review granted: [Bug 186151] [Datalist] Allow TextFieldInputType to show and hide suggestions : [Attachment 342186] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 7 17:33:39 PDT 2018
Tim Horton <thorton at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 186151: [Datalist] Allow TextFieldInputType to show and hide suggestions
https://bugs.webkit.org/show_bug.cgi?id=186151
Attachment 342186: Patch
https://bugs.webkit.org/attachment.cgi?id=342186&action=review
--- Comment #9 from Tim Horton <thorton at apple.com> ---
Comment on attachment 342186
--> https://bugs.webkit.org/attachment.cgi?id=342186
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=342186&action=review
> Source/WebCore/html/TextFieldInputType.cpp:568
> +#if ENABLE(DATALIST_ELEMENT)
> + return true;
> +#else
> return InputType::themeSupportsDataListUI(this);
> +#endif
How does this work? If the control theme doesn’t support the UI for suggestion
lists, how does this patch make it work?
More information about the webkit-reviews
mailing list