[webkit-reviews] review granted: [Bug 186387] [Win][MiniBrowser] Convert MiniBrowser::updateDeviceScaleFactor to a MainWindow's method : [Attachment 342139] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 7 13:15:14 PDT 2018


Ryosuke Niwa <rniwa at webkit.org> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 186387: [Win][MiniBrowser] Convert MiniBrowser::updateDeviceScaleFactor to
a MainWindow's method
https://bugs.webkit.org/show_bug.cgi?id=186387

Attachment 342139: Patch

https://bugs.webkit.org/attachment.cgi?id=342139&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 342139
  --> https://bugs.webkit.org/attachment.cgi?id=342139
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342139&action=review

> Tools/MiniBrowser/win/MainWindow.cpp:426
> +    m_hURLBarFont = ::CreateFont(scaleFactor * 18, 0, 0, 0, FW_NORMAL,
FALSE, FALSE, FALSE, DEFAULT_CHARSET,

Where did 18 come from!?


More information about the webkit-reviews mailing list