[webkit-reviews] review granted: [Bug 186402] REGRESSION(r224134) Client certificate challenges don't always appear : [Attachment 342189] Patch

[bugzilla-daemon at webkit.org]

Brian Weinstein <bweinstein at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 186402: REGRESSION(r224134) Client certificate challenges don't always
appear
https://bugs.webkit.org/show_bug.cgi?id=186402

Attachment 342189: Patch

https://bugs.webkit.org/attachment.cgi?id=342189&action=review




--- Comment #3 from Brian Weinstein <bweinstein at apple.com> ---
Comment on attachment 342189
  --> https://bugs.webkit.org/attachment.cgi?id=342189
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342189&action=review

> Source/WebKit/NetworkProcess/NetworkLoad.cpp:340
> +    bool isTLSHandshake =
m_challenge->protectionSpace().authenticationScheme() ==
ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested

Is it worth pulling m_challenge->protectionSpace().authenticationScheme() into
a local?