[webkit-reviews] review granted: [Bug 186376] Use the same overloaded addInputString in WKContentViewInteraction : [Attachment 342104] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 7 10:51:56 PDT 2018


Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 186376: Use the same overloaded addInputString in WKContentViewInteraction
https://bugs.webkit.org/show_bug.cgi?id=186376

Attachment 342104: Patch

https://bugs.webkit.org/attachment.cgi?id=342104&action=review




--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 342104
  --> https://bugs.webkit.org/attachment.cgi?id=342104
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342104&action=review

r=me! Nice find.

> Source/WebKit/ChangeLog:10
> +	   overloaded varaint consistently: [UIKeyboardImpl
-addInputString:withFlags:withInputManagerHint:].

variant (the I/a are transposed)


More information about the webkit-reviews mailing list