[webkit-reviews] review granted: [Bug 186378] [Win][MiniBrowser] Remove gMainWindow global variable : [Attachment 342107] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 6 22:33:31 PDT 2018


Ryosuke Niwa <rniwa at webkit.org> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 186378: [Win][MiniBrowser] Remove gMainWindow global variable
https://bugs.webkit.org/show_bug.cgi?id=186378

Attachment 342107: Patch

https://bugs.webkit.org/attachment.cgi?id=342107&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 342107
  --> https://bugs.webkit.org/attachment.cgi?id=342107
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342107&action=review

> Tools/MiniBrowser/win/Common.cpp:139
> +	       int strLen = GetWindowText(GetDlgItem(hDlg, IDC_AUTH_USER), str,
256);

Can we use WTF_ARRAY_LENGTH or sizeof(str) / sizeof(*str) or std::size instead
of hard-coding 256 twice?

> Tools/MiniBrowser/win/Common.cpp:143
> +	       strLen = GetWindowText(GetDlgItem(hDlg, IDC_AUTH_PASSWORD), str,
256);

Ditto.


More information about the webkit-reviews mailing list