[webkit-reviews] review granted: [Bug 186352] webkitperl: Generalize .internal SDK suffix : [Attachment 342096] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 6 20:13:13 PDT 2018
Alexey Proskuryakov <ap at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 186352: webkitperl: Generalize .internal SDK suffix
https://bugs.webkit.org/show_bug.cgi?id=186352
Attachment 342096: Patch
https://bugs.webkit.org/attachment.cgi?id=342096&action=review
--- Comment #12 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 342096
--> https://bugs.webkit.org/attachment.cgi?id=342096
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=342096&action=review
> Tools/Scripts/webkitdirs.pm:508
> +sub parseAvailableXcodeSDKS($)
I think that the last s should be lower case.
> Tools/Scripts/webkitdirs.pm:528
> +sub availableXcodeSDKS
Ditto.
More information about the webkit-reviews
mailing list