[webkit-reviews] review granted: [Bug 186370] Crash in lambda function WTF::Function<void ()>::CallableWrapper<WebKit::DisplayLink::displayLinkCallback : [Attachment 342095] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 186370: Crash in lambda function WTF::Function<void
()>::CallableWrapper<WebKit::DisplayLink::displayLinkCallback
https://bugs.webkit.org/show_bug.cgi?id=186370

Attachment 342095: Patch

https://bugs.webkit.org/attachment.cgi?id=342095&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 342095
  --> https://bugs.webkit.org/attachment.cgi?id=342095
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=342095&action=review

r=me, if EWS is satisfied.

> Source/WebKit/UIProcess/mac/DisplayLink.cpp:101
> +    RunLoop::main().dispatch([weakPtr = webPageProxy->createWeakPtr()] {

You should be able to use "weakPtr = makeWeakPtr(*webPageProxy)"