[webkit-reviews] review requested: [Bug 184588] [GStreamer] Fix the way GstStreamCollection is handled : [Attachment 342084] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 6 15:22:00 PDT 2018


Thibault Saunier <tsaunier at gnome.org> has asked  for review:
Bug 184588: [GStreamer] Fix the way GstStreamCollection is handled
https://bugs.webkit.org/show_bug.cgi?id=184588

Attachment 342084: Patch.

https://bugs.webkit.org/attachment.cgi?id=342084&action=review




--- Comment #14 from Thibault Saunier <tsaunier at gnome.org> ---
Created attachment 342084

  --> https://bugs.webkit.org/attachment.cgi?id=342084&action=review

Patch.

(In reply to Philippe Normand from comment #13)
> Comment on attachment 341757 [details]
> Rebased version of the patch taking into account previous comments and
> fixing little details
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=341757&action=review
> 
> >
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:700
> > +#undef CLEAR_TRACKS
> 
> This looks like a duplicate.

Fixed.


More information about the webkit-reviews mailing list