[webkit-reviews] review requested: [Bug 132333] [CLOOP] Operand in PutToScope and GetFromScope is not set right causing crashes on big endian arches : [Attachment 342072] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 6 12:31:19 PDT 2018
Caitlin Potter (:caitp) <caitp at igalia.com> has asked for review:
Bug 132333: [CLOOP] Operand in PutToScope and GetFromScope is not set right
causing crashes on big endian arches
https://bugs.webkit.org/show_bug.cgi?id=132333
Attachment 342072: Patch
https://bugs.webkit.org/attachment.cgi?id=342072&action=review
--- Comment #27 from Caitlin Potter (:caitp) <caitp at igalia.com> ---
Created attachment 342072
--> https://bugs.webkit.org/attachment.cgi?id=342072&action=review
Patch
Here's my shot at this. Instead of adding conditional logic which could be hard
to maintain, it changes get_from/put_to_scope to be consistent about always
using loadp instead of loadis to get at the operand, and adds an intptr_t
accessor to the Instruction union, though it isn't strictly needed.
More information about the webkit-reviews
mailing list